Skip to content

Small fixes to concurrency material #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025
Merged

Small fixes to concurrency material #2737

merged 4 commits into from
May 23, 2025

Conversation

fw-immunant
Copy link
Collaborator

@fw-immunant fw-immunant commented May 5, 2025

See individual commits.

@fw-immunant fw-immunant force-pushed the fw/concurrency-fixes branch from ab4a5dc to ac18f49 Compare May 5, 2025 21:28
@fw-immunant fw-immunant force-pushed the fw/concurrency-fixes branch 2 times, most recently from 59f3ab3 to ae231ce Compare May 6, 2025 15:57
Ownership is the responsibility to free a value. Previously, `v` was
always freed by the main thread because it kept the original `Arc`
instance. It was difficult to explain why this example did not simply
use scoped threads instead.

Now we see that multi-threaded dynamic ownership with `Arc` results
in a dynamic decision of which thread will clean up a given value.
@fw-immunant fw-immunant force-pushed the fw/concurrency-fixes branch from ae231ce to 683271a Compare May 6, 2025 18:46
@fw-immunant fw-immunant force-pushed the fw/concurrency-fixes branch from 683271a to 6e92ef1 Compare May 7, 2025 16:38
@fw-immunant
Copy link
Collaborator Author

Can someone merge without squashing?

@djmitche
Copy link
Collaborator

djmitche commented May 7, 2025

Looks like I can only "Squash and merge" -- I assume an admin is required to override that.

@randomPoison
Copy link
Collaborator

@mgeisler probably has the power

@qwandor
Copy link
Collaborator

qwandor commented May 23, 2025

I believe he has it configured to only allow squashes.

@djmitche
Copy link
Collaborator

Well, let's get this in even squashed..

@djmitche djmitche merged commit c60070b into main May 23, 2025
38 checks passed
@djmitche djmitche deleted the fw/concurrency-fixes branch May 23, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants